simple changes #1219
Closed
simple changes #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@jsheunis could you review this? 🙏 |
|
Thanks for tagging me, will review it 👍 |
jsheunis
suggested changes
Apr 23, 2024
There was a problem hiding this comment.
Thanks for the PR @CPernet. Two points:
- The addition of the commas in the catalog file are fine, those can be merged.
- The additional note about WSL2 for windows installation is actually already covered in a note further down on that same page:
.. windows-wit:: Install DataLad using the Windows Subsystem 2 for Linux
:name: ww-wsl2
With the Windows Subsystem for Linux, you will be able to use a Unix system
despite being on Windows. You need to have a recent build of Windows in
order to get WSL2 -- we do not recommend WSL1.
You can find out how to install the Windows Subsystem for Linux at
`docs.microsoft.com <https://learn.microsoft.com/en-us/windows/wsl/install>`_.
Afterwards, proceed with your installation as described in the installation instructions
for Linux.
So I would say the change to installation.rst is not necessary. Could you remove that commit from the PR?
|
pushing a clean one instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add some windows subsystem info
fix some comma issue for DataCat example